Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [+] collection functions (issue #64) #287

Merged
merged 11 commits into from
Apr 20, 2023

Conversation

eruizalo
Copy link
Collaborator

@eruizalo eruizalo commented Oct 7, 2022

Description

New collection & struct functions

⚠️⚠️ DO NOT MERGE UNTIL TODOS RESOLUTION ⚠️⚠️

Related Issue and dependencies

How Has This Been Tested?

  • This pull request contains appropriate tests?:
    • YES

@github-actions github-actions bot added CI/CD Continuous integration and continuous delivery spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3 labels Oct 7, 2022
@eruizalo eruizalo mentioned this pull request Oct 7, 2022
74 tasks
@eruizalo eruizalo force-pushed the feat/64_collection_functions branch 2 times, most recently from af6009f to 7cd70a1 Compare October 10, 2022 12:34
@github-actions github-actions bot removed the CI/CD Continuous integration and continuous delivery label Oct 25, 2022
@github-actions
Copy link

github-actions bot commented Oct 25, 2022

:octocat: This is an auto-generated comment created by:

  • Date : 2023-04-20 12:31:19 +0000 (UTC)
  • Workflow : PR comment
  • Job name : create_test_summary_report
  • Run : 4754290663
  • Commit : 5cb35dc fix zip_with tests for spark < 3.0.0
Actor Triggering actor Sender
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
Triggered by:

Test summary report 📊

Spark version testing
2.4.1 623 passed, 2 skipped
2.4.2 623 passed, 2 skipped
2.4.3 623 passed, 2 skipped
2.4.4 623 passed, 2 skipped
2.4.5 623 passed, 2 skipped
2.4.6 624 passed, 2 skipped
2.4.7 624 passed, 2 skipped
2.4 624 passed, 2 skipped
3.0.0 674 passed, 2 skipped
3.0.1 674 passed, 2 skipped
3.0.2 674 passed, 2 skipped
3.0 674 passed, 2 skipped
3.1.0 702 passed, 2 skipped
3.1.1 702 passed, 2 skipped
3.1.2 702 passed, 2 skipped
3.1 702 passed, 2 skipped
3.2.0 706 passed, 2 skipped
3.2.1 706 passed, 2 skipped
3.2.2 706 passed, 2 skipped
3.2 706 passed, 2 skipped
3.3.0 706 passed, 2 skipped
3.3.1 706 passed, 2 skipped
3.3 706 passed, 2 skipped

@github-actions github-actions bot added the CI/CD Continuous integration and continuous delivery label Oct 25, 2022
@eruizalo eruizalo force-pushed the feat/64_collection_functions branch 5 times, most recently from a9af4b0 to 8a7718c Compare November 2, 2022 11:41
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #287 (ab436df) into main (aacd432) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   97.50%   97.60%   +0.10%     
==========================================
  Files          61       62       +1     
  Lines        1201     1249      +48     
  Branches       20       23       +3     
==========================================
+ Hits         1171     1219      +48     
  Misses         30       30              
Flag Coverage Δ
spark-2.4.x 94.66% <100.00%> (+0.21%) ⬆️
spark-3.0.x 96.74% <100.00%> (+0.14%) ⬆️
spark-3.1.x 97.48% <100.00%> (+0.10%) ⬆️
spark-3.2.x 97.70% <100.00%> (+0.09%) ⬆️
spark-3.3.x 97.70% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
core/src/main/scala/doric/DoricColumn.scala 66.67% <ø> (ø)
...re/src/main/scala/doric/syntax/CommonColumns.scala 100.00% <ø> (ø)
...ore/src/main/scala/doric/syntax/ArrayColumns.scala 100.00% <100.00%> (ø)
core/src/main/scala/doric/syntax/DStructs.scala 100.00% <100.00%> (ø)
core/src/main/scala/doric/syntax/MapColumns.scala 100.00% <100.00%> (ø)
...re/src/main/scala/doric/syntax/StringColumns.scala 100.00% <100.00%> (ø)
..._2.4_mount/scala/doric/syntax/StringColumn24.scala 100.00% <100.00%> (ø)
....0_3.1_3.2_3.3/scala/doric/syntax/DStructs3x.scala 100.00% <100.00%> (ø)
..._3.1_3.2_3.3/scala/doric/syntax/MapColumns3x.scala 100.00% <100.00%> (ø)
....1_3.2_3.3/scala/doric/syntax/StringColumn3x.scala 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aacd432...ab436df. Read the comment docs.

@eruizalo eruizalo force-pushed the feat/64_collection_functions branch 2 times, most recently from aacdb28 to 086f0ed Compare January 22, 2023 13:59
@github-actions github-actions bot removed the CI/CD Continuous integration and continuous delivery label Jan 22, 2023
@eruizalo eruizalo self-assigned this Mar 14, 2023
@eruizalo eruizalo force-pushed the feat/64_collection_functions branch from 086f0ed to 36e3985 Compare April 20, 2023 11:41
@eruizalo eruizalo force-pushed the feat/64_collection_functions branch from 225db06 to 5cb35dc Compare April 20, 2023 12:18
@eruizalo eruizalo force-pushed the feat/64_collection_functions branch from 61d05d3 to ab436df Compare April 20, 2023 14:18
@eruizalo eruizalo marked this pull request as ready for review April 20, 2023 15:16
@eruizalo eruizalo requested a review from a team as a code owner April 20, 2023 15:16
@eruizalo eruizalo merged commit b42bfdb into hablapps:main Apr 20, 2023
53 checks passed
@eruizalo eruizalo deleted the feat/64_collection_functions branch April 20, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection functions
2 participants