Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [+] decimal round with mode & (array) mkString functions #354

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

eruizalo
Copy link
Collaborator

@eruizalo eruizalo commented May 9, 2023

Description

(relatively ) new doric functions:

  • Array[String] columns:
    • there is now a function called mkString like scala. Actually it is the concat_ws function from spark.
  • Decimals columns:
    • there is now a round function which lets you choose the round mode given a number of decimals

Related Issue and dependencies

  • Resolves N/A
  • Depends on N/A

How Has This Been Tested?

  • This pull request contains appropriate tests?:
    • YES

@eruizalo eruizalo requested a review from a team as a code owner May 9, 2023 14:30
@github-actions github-actions bot added spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3 labels May 9, 2023
@eruizalo eruizalo added enhancement New feature or request API labels May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

:octocat: This is an auto-generated comment created by:

  • Date : 2023-11-07 13:04:33 +0000 (UTC)
  • Workflow : PR comment
  • Job name : create_test_summary_report
  • Run : 6784894058
  • Commit : 9fb606e fix: testing
Actor Triggering actor Sender
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
Triggered by:

Test summary report 📊

Spark version testing
3.0.0 685 passed, 2 skipped
3.0.1 685 passed, 2 skipped
3.0.2 685 passed, 2 skipped
3.0 685 passed, 2 skipped
3.1.0 713 passed, 2 failed, 2 skipped
3.1.1 713 passed, 2 failed, 2 skipped
3.1.2 713 passed, 2 failed, 2 skipped
3.1 713 passed, 2 failed, 2 skipped
3.2.0 719 passed, 2 skipped
3.2.1 719 passed, 2 skipped
3.2.2 719 passed, 2 skipped
3.2 719 passed, 2 skipped
3.3.0 719 passed, 2 skipped
3.3.1 719 passed, 2 skipped
3.3 719 passed, 2 skipped
3.4 719 passed, 2 skipped

@eruizalo eruizalo force-pushed the feat/new_functions branch 2 times, most recently from 2ff84a5 to 9d00961 Compare May 9, 2023 14:47
@github-actions github-actions bot added the spark_3.4 PR changes to spark 3.4 label Aug 12, 2023
@eruizalo eruizalo force-pushed the feat/new_functions branch 2 times, most recently from 0b8b50e to bdaa071 Compare August 15, 2023 09:54
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #354 (9fb606e) into main (6aeb249) will decrease coverage by 0.22%.
The diff coverage is 70.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
- Coverage   97.69%   97.47%   -0.22%     
==========================================
  Files          62       62              
  Lines        1255     1264       +9     
  Branches       37       33       -4     
==========================================
+ Hits         1226     1232       +6     
- Misses         29       32       +3     
Flag Coverage Δ
spark-3.0.x 96.48% <50.00%> (-0.24%) ⬇️
spark-3.1.x ?
spark-3.2.x 97.67% <100.00%> (+0.01%) ⬆️
spark-3.3.x 97.67% <100.00%> (+0.01%) ⬆️
spark-3.4.x 97.67% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ore/src/main/scala/doric/syntax/ArrayColumns.scala 100.00% <100.00%> (ø)
...e/src/main/scala/doric/syntax/NumericColumns.scala 100.00% <ø> (ø)
..._3.3_3.4/scala/doric/syntax/NumericColumns32.scala 100.00% <100.00%> (ø)
....0_3.1/scala/doric/syntax/NumericColumns2_31.scala 76.92% <0.00%> (-23.08%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aeb249...9fb606e. Read the comment docs.

@eruizalo eruizalo force-pushed the feat/new_functions branch 3 times, most recently from 235709e to b8b62b2 Compare August 16, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3 spark_3.4 PR changes to spark 3.4
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant