Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add get_observation and get_observation_for_place in client #520

Merged
merged 5 commits into from Feb 22, 2023
Merged

feat: add get_observation and get_observation_for_place in client #520

merged 5 commits into from Feb 22, 2023

Conversation

bbesset
Copy link
Contributor

@bbesset bbesset commented Dec 19, 2022

This new feature fetches current observation from the v2/observation API endpoint.

@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bbesset bbesset mentioned this pull request Dec 19, 2022
Closed
@bbesset
Copy link
Contributor Author

bbesset commented Jan 15, 2023

hello @oncleben31 @dx44 @Quentame, could you please review ?

Quentame
Quentame requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR !
But need few changes 😅

That would be awesome if you could add some tests 😉

src/meteofrance_api/client.py Show resolved Hide resolved
src/meteofrance_api/client.py Show resolved Hide resolved
src/meteofrance_api/model/observation.py Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bbesset bbesset requested review from Quentame and removed request for oncleben31 and dx44 January 22, 2023 09:17
@Quentame Quentame added the enhancement New feature or request label Feb 22, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Quentame
Quentame approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 🎉

@Quentame Quentame merged commit 41a68f7 into hacf-fr:master Feb 22, 2023
@Quentame Quentame mentioned this pull request Feb 22, 2023
Merged
@Quentame
Copy link
Member

Apparently the CI isn't working since this PR, odd I thought I saw it passing here.

@Quentame Quentame mentioned this pull request Feb 22, 2023
Merged
19 tasks
@bbesset bbesset deleted the feat-add-observation branch March 4, 2023 10:34
@dx44 dx44 linked an issue May 3, 2023 that may be closed by this pull request
Use the v2/observation API endpoint #521
Closed
@mlemainque mlemainque mentioned this pull request Dec 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quentame Quentame Quentame approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the v2/observation API endpoint
2 participants
@bbesset @Quentame