Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HACF and Discord links when creating a new issue #57

Merged
merged 3 commits into from
Oct 18, 2020
Merged

Add HACF and Discord links when creating a new issue #57

merged 3 commits into from
Oct 18, 2020

Conversation

dav1dddd
Copy link
Contributor

@dav1dddd dav1dddd commented Oct 12, 2020

Add HACF discord server and forums when creating new issue

fix: #56

Copy link
Member

@oncleben31 oncleben31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Can you add details in the description of the links

contact_links:
- name: HACF Discord
url: https://discord.gg/PaZFEjX
about: The HACF discord server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. To motivate user to use Discord and Foru, can you put details in the about key explaining why they should use the discord. It could be good idea to specify the Discord is french speaking.

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
@oncleben31 oncleben31 added the documentation Improvements or additions to documentation label Oct 12, 2020
@oncleben31
Copy link
Member

Can you please make a link to the issue #56 in the PR description and edit your PR title to be more understandable.
FYI, the PR title will be reuse in the release note.

@dav1dddd
Copy link
Contributor Author

I did add an empty newline, but the checks still failed, not sure why

Copy link
Member

@oncleben31 oncleben31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution.

@oncleben31
Copy link
Member

I did add an empty newline, but the checks still failed, not sure why

The last newline need to be empty. It's currently not.

@oncleben31 oncleben31 changed the title Add files via upload Add HACF and Discord links when creating a new issue Oct 13, 2020
@oncleben31 oncleben31 linked an issue Oct 13, 2020 that may be closed by this pull request
Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍
Thanks for contributing.

Just a like correction

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          389       389           
  Branches        23        23           
=========================================
  Hits           389       389           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d6ce7...c32acc2. Read the comment docs.

@Quentame Quentame merged commit 31bc809 into hacf-fr:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to HACF Discord and forums.
3 participants