Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cockpit endpoint #1145

Merged
merged 2 commits into from Apr 17, 2024
Merged

Update Cockpit endpoint #1145

merged 2 commits into from Apr 17, 2024

Conversation

Konubinix
Copy link
Contributor

fixes #1135

@epenet
Copy link
Collaborator

epenet commented Apr 16, 2024

Please update tests accordingly

@epenet
Copy link
Collaborator

epenet commented Apr 16, 2024

I assume at the very least it's going to be

renault-api/tests/fixtures.py

Line 392 in 3595464

urlpath = f"{ADAPTER2_PATH}/cockpit?{DEFAULT_QUERY_STRING}"

(replacing ADAPTER2_PATH with ADAPTER_PATH)

@epenet epenet added the bug Something isn't working label Apr 16, 2024
epenet
epenet approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epenet epenet merged commit 356cf6a into hacf-fr:main Apr 17, 2024
16 checks passed
@epenet epenet changed the title fix: Go back to Version 1 for Cockpit Endpoint Update Cockpit endpoint Apr 17, 2024
@epenet epenet mentioned this pull request Apr 17, 2024
Merged
20 tasks
@Konubinix
Copy link
Contributor Author

Konubinix commented Apr 17, 2024 •
edited

Thank you for doing it yourself :-). In the future, I'll do my best to edit the tests also.

@epenet epenet mentioned this pull request Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epenet epenet epenet approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vehicle.get_cockpit() returns {"message": "you should not be there but well done for the effort"}
2 participants
@Konubinix @epenet