Skip to content

Commit

Permalink
Fix from Martin Atkins, don't print() in the Gearman::Util code and c…
Browse files Browse the repository at this point in the history
…lose sockets

when you have an error of some kind (indicating we're out of sync)

git-svn-id: http://code.sixapart.com/svn/gearman/trunk@451 011c6a6d-750f-0410-a5f6-93fdcd050bc4
  • Loading branch information
hachi committed Nov 10, 2009
1 parent b29b9f3 commit 1cc0e76
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGES
@@ -1,3 +1,6 @@
-- Fix from Martin Atkins, don't print() in the Gearman::Util code and close sockets
when you have an error of some kind (indicating we're out of sync)

1.10 (2009-10-04)

-- Make workers wake up periodically for a particular server to make sure they aren't
Expand Down
1 change: 0 additions & 1 deletion lib/Gearman/Taskset.pm
Expand Up @@ -208,7 +208,6 @@ sub add_task {
if (! $rv) {
shift @{ $ts->{need_handle} }; # ditch it, it failed.
# this will resubmit it if it failed.
print " INITIAL SUBMIT FAILED\n";
return $task->fail;
}
}
Expand Down
1 change: 1 addition & 0 deletions lib/Gearman/Util.pm
Expand Up @@ -89,6 +89,7 @@ sub read_res_packet {

my $err = sub {
my $code = shift;
$sock->close() if $sock->connected;
$$err_ref = $code if ref $err_ref;
return undef;
};
Expand Down

0 comments on commit 1cc0e76

Please sign in to comment.