new manager option to create admin user with prompts

[aharelick]

@sandlerben can you take a look. Having to create a function like this might be the tipping point for me in terms of us possibly thinking about another workflow for when someone starts coding.

[aharelick]

Or do we want to reference something like this from setup_dev because the only reason you should be inserting roles is if you've cleared the database?

[sandlerben]

Would you want to move this into the add_fake_data command? Three options:

1. People can pass in an email and password to the add_fake_data command.
2. Each team can set an admin account which is always created when they call setup_dev. For example, for GPCAH, we had an account ben@ben.com with password password.
3. When debug=True we can add an option to the registration form to select your role.

[sandlerben]

What do you mean by

Or do we want to reference something like this from setup_dev because the only reason you should be inserting roles is if you've cleared the database?

[jondubin]

We modified user creation so that the first user created is the admin. AFAIK this is a pretty standard practice

[sandlerben]

I personally prefer option 3 actually, but that's a good idea Dubin. Let's leave this out of flask-base for now and come together on a solution at the end of the semester.

[aharelick]

I'm going to implement option 2. I like option 3 as well, but I don't feel great about having something like this that entrenched in the code when we aren't set on it as a solution for everything.

[aharelick]

Can you guys just give it a quick once over before I merge it, thanks.

[sandlerben]

Sure. You should have someone from your team review too!

[sandlerben]

Nit: parenthesis around statements are not Pythonic

Did flake8 not get mad about this?

[aharelick]

It's actually not a pep8 thing, just a pycharm thing. But you're right, they are redundant.

[sandlerben]

should be, let's amend pep8

[jondubin]

Related: more pythonic would be if not User.query.filter_by(email=email).first(): Whether it's more/less readable, I'll let you decide

[sandlerben]

Left a few small comments, besides that lgtm

[aharelick]

Thanks guys, I appreciate it.

[sandlerben]

@jondubin what he currently has is better than if not User.query.filter_by(email=email).first():

From PEP8:

Comparisons to singletons like None should always be done with 'is' or 'is not', never the equality operators.

Also, beware of writing "if x" when you really mean "if x is not None" -- e.g. when testing whether a variable or argument that defaults to None was set to some other value. The other value might have a type (such as a container) that could be false in a boolean context!

[aharelick]