Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier #12

Merged
merged 3 commits into from Oct 7, 2019

Conversation

@michaelneu
Copy link
Member

commented Oct 5, 2019

No description provided.

@michaelneu michaelneu force-pushed the dx/prettier branch from 3e3b49f to 4793ff9 Oct 7, 2019
@michaelneu michaelneu force-pushed the dx/prettier branch from 4793ff9 to 5bae6b7 Oct 7, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Oct 7, 2019

Codecov Report

Merging #12 into master will decrease coverage by 0.72%.
The diff coverage is 56.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   71.88%   71.16%   -0.73%     
==========================================
  Files         120      120              
  Lines        2049     2185     +136     
  Branches      323      338      +15     
==========================================
+ Hits         1473     1555      +82     
- Misses        576      630      +54
Flag Coverage Δ
#backend 80.12% <70.24%> (-0.19%) ⬇️
#frontend 62.21% <44.32%> (-1.23%) ⬇️
Impacted Files Coverage Δ
backend/test/services/mock/index.ts 100% <ø> (ø) ⬆️
frontend/src/components/placeholder.tsx 80% <ø> (ø) ⬆️
frontend/src/components/fade-container.tsx 60% <0%> (-15%) ⬇️
frontend/src/components/headerbar.tsx 60% <0%> (-15%) ⬇️
frontend/src/components/form-editor.tsx 30.23% <0%> (-0.72%) ⬇️
frontend/src/components/activity-event.tsx 36.84% <0%> (ø) ⬆️
frontend/src/components/blur-container.tsx 60% <0%> (-15%) ⬇️
frontend/src/components/login-image.tsx 68.75% <0%> (+4.04%) ⬆️
frontend/src/components/page-wrapper.tsx 67.85% <0%> (-8.15%) ⬇️
frontend/src/components/notification.tsx 66.66% <0%> (-6.07%) ⬇️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cc1e19...5bae6b7. Read the comment docs.

@michaelneu michaelneu marked this pull request as ready for review Oct 7, 2019
@phntxx phntxx marked this pull request as ready for review Oct 7, 2019
@phntxx
phntxx approved these changes Oct 7, 2019
Copy link
Contributor

left a comment

works

@phntxx phntxx merged commit 76243f3 into master Oct 7, 2019
2 checks passed
2 checks passed
ci/circleci: backend Your tests passed on CircleCI!
Details
ci/circleci: frontend Your tests passed on CircleCI!
Details
@michaelneu michaelneu deleted the dx/prettier branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.