Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ fixed #2 ] Removed instances defined by regex-base 0.94.0.0. #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asr
Copy link

@asr asr commented Sep 28, 2019

This PR fix #2.

…0.94.0.0.

Also added lower bound (0.94.0.0) for regex-base.
@sjakobi
Copy link

sjakobi commented Oct 7, 2019

Bump! :)

@hvr
Copy link

hvr commented Oct 11, 2019

fwiw, I'd rather deprecate regex-tdfa-text and merge it into regex-tdfa which I'm now maintainer of as well

@asr
Copy link
Author

asr commented Oct 14, 2019

@hvr, I'm confused. Why did you fork regex-tdfa if it is well maintained here.

BTW, in Agda we use regex-tdfa-text because ChrisKuklewicz/regex-tdfa#5.

@sjakobi
Copy link

sjakobi commented Oct 18, 2019

Can we let the perfect not stand in the way of the good and just get a release that is compatible with GHC-8.8? :)

@sjakobi
Copy link

sjakobi commented Oct 30, 2019

Bump! This looks like it could be released without much further ado, while work on haskell-hvr/regex-tdfa#4 hasn't even started.

@maoe
Copy link

maoe commented Nov 25, 2019

I confirmed this patch builds fine with GHC 8.8.1. This package is used by ghc-dump-util so it would be great if this was accepted.

@hvr
Copy link

hvr commented Nov 25, 2019

The master branch of https://github.com/haskell-hvr/regex-tdfa has the Text bits merged; I plan to polish it up asap and release it either tonight or at the latest tomorrow (UPDATE: see regex-tdfa-1.3.1.0) unless show-blocker bugs exhibit.

Feel free to give it a testrun, and report any issues (ideally with fixes) of any issues you might encounter; this would help avoid any further delay to get this issue resolved at last.

@maoe
Copy link

maoe commented Nov 26, 2019

I've confirmed that ghc-dump seems to work fine with the latest master of regex-tdfa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error using regex-base 0.94.0.0
4 participants