Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracespace should link to "All layers" view instead of "top" #348

Closed
maxwofford opened this issue Feb 20, 2024 · 2 comments · Fixed by #369
Closed

Tracespace should link to "All layers" view instead of "top" #348

maxwofford opened this issue Feb 20, 2024 · 2 comments · Fixed by #369

Comments

@maxwofford
Copy link
Member

Currently our auto-generated tracespace comment (ex. #323 (comment)) shows up on PRs so people can quickly preview new boards. This is nifty and cool, but the default view looks broken. We should link them to "All layers" instead, which looks correct
Screenshot 2024-02-20 at 12 53 51

@karmanyaahm
Copy link
Member

karmanyaahm commented Mar 6, 2024

I made a custom fork of tracespace that has a 'mode' url parameter. I also mostly fixed the broken board issue by increasing the default gap filling distance. Regardless, I will update our automations to show the layer mode because that's a lot more meaningful and transparent/educational than the pretty 'top' view.

Here's an example: https://gerber.zip/2d/?mode=layers&boardUrl=https://raw.githubusercontent.com/hackclub/OnBoard/6b11e9eae59783bd3c8d29f791d01d4e5c90d03d/projects/Alex P's NFC Card/gerber.zip

@maxwofford
Copy link
Member Author

Still can't believe you got that domain. So cool to see this in action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants