This repository has been archived by the owner on Dec 6, 2019. It is now read-only.
add ruhrgebiet to map #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +14,7 @@ $ -> | |||
|
|
|||
| koeln = new L.Popup() | |||
| koeln.setLatLng([50.938056,6.956944]) | |||
| koeln.setContent("<a href='/move_to/koeln'>Köln</a>") | |||
| koeln.setContent("<a href='/move_to/koeln'>Köln</a>") | |||
There was a problem hiding this comment.
This looks like the encoding is broken now. Can you check that again?
|
There seems to be something wrong with the encoding (or is it just broken in the web view?). Apart from that it looks great 👍 Thanks, Jan!!! |
|
Ugh, my bad, I fix that, sorry! |
|
Thanks to both of you then 😄 |
|
@moonglum should be fixed now |
|
Awesome 👍 Let's check it out on staging, and then we do a big release with tweets and everything – alright with you, Mr. @bitboxer ? |
|
Yes, go ahead! 🚢 |
|
It's on staging now:
When I click on 'Ruhrgebiet' though, I get redirected to the start page. Is that due to missing data on staging? Or are there other reasons for that? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #597
Took the changes from https://gist.github.com/madeleine-neumann/ae5740ea3ec1d6d90678/revisions and created a PR
@moonglum @madeleine-neumann