Cities on map #84
Merged
Cities on map #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
- This makes sure that we don't hit nominatim unless we have to
|
@krsoninikhil I've added cache support, so now the builds are running pretty fast. Also added geo.json to gitignore since its not meant to be committed. You can merge this once you have reviewed it 👍 |
|
That's better, I didn't know about the api response caching, thanks for pointing out. |
|
Its getting some issues with not importing leaflet over https |
Closed
|
We don't want to commit the cache to git, because its not the "source" for the repo, and can always be regenerated. |
|
Okay. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes work by @krsoninikhil. I refactored slightly to remove the json by-hand generator.
The only thing missing is a cache support, and as a result the generator is very slow. Since this is run on every build, it makes testing and working on hackercouch really slow.
Travis supports proper file-based caches (every build gets the same cache). We can use that to store the API responses from nominatim.