Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bookcard UI responsiveness #231

Merged
merged 8 commits into from
Oct 18, 2020
Merged

Conversation

paymin
Copy link
Contributor

@paymin paymin commented Oct 10, 2020

I would like to improve your UI responsiveness so it can fit to any device screen width.
ezgif com-video-to-gif

I also want to modified the sidebar to be responsive for the next PR.

@paymin paymin changed the title Improve bookcard UI Improve bookcard UI responsiveness Oct 10, 2020
@TriinK
Copy link
Contributor

TriinK commented Oct 10, 2020

Maybe also add a hamburger menu in mobile view?

@hackerkid
Copy link
Owner

Maybe also add a hamburger menu in mobile view?

Yes. We should improve the mobile view. It's less than ideal at the moment. @paymin Can you take care of that as well?

@paymin
Copy link
Contributor Author

paymin commented Oct 11, 2020

Yes, it sounds good. I'll take care of that

@paymin
Copy link
Contributor Author

paymin commented Oct 11, 2020

hey @hackerkid i have just added the 🍔 menu
may be helping #236

ezgif com-video-to-gif(1)

@hackerkid
Copy link
Owner

@paymin These changes look great. Can you take care of the merge conflicts as well? I will merge right after that.

@paymin
Copy link
Contributor Author

paymin commented Oct 13, 2020

@hackerkid sure

@hackerkid
Copy link
Owner

@paymin Have you fixed conflicts and rebased on top of master?

@paymin
Copy link
Contributor Author

paymin commented Oct 15, 2020

I've just resolved the conflict, it's now run smoothly with your latest master. Please tell me if I missed something else.

@hackerkid
Copy link
Owner

@paymin I am really sorry. Some more conflicts came while I was merging other PRs. Can you fix the conflicts one last time.

@hackerkid
Copy link
Owner

@paymin Is this ready for review? The save to reading list button seems to be missing.
https://deploy-preview-231--mind-expanding-books.netlify.app/

@hackerkid hackerkid merged commit 97522a0 into hackerkid:master Oct 18, 2020
@hackerkid
Copy link
Owner

@paymin Thanks a lot for working on this. Merged thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants