Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical bidding round #36

Merged
merged 9 commits into from
Nov 22, 2022
Merged

Physical bidding round #36

merged 9 commits into from
Nov 22, 2022

Conversation

Fueredoriku
Copy link
Collaborator

@Fueredoriku Fueredoriku commented Nov 15, 2022

  • Create a physical bidding round scene
  • Integrate bidding round to MatchManager (It redirects to bidding after each round)
  • Created new inputMap specifically for bidding
  • Merged playerInventory into playerManager

I intentionally chose not to track bidding rounds like we do rounds, with the reasoning being the following

  • Results of the bidding round only affect a player's inventory, which should be stored in PlayerManager.
  • I have yet to come up with a good use case for tracking the result of every bidding round from a match.
    • If such a use case is found, it wouldn't be hard to refactor the code to allow for similar functionality as Round

@Fueredoriku Fueredoriku changed the base branch from main to dev November 15, 2022 13:20
@Fueredoriku Fueredoriku linked an issue Nov 15, 2022 that may be closed by this pull request
10 tasks
- MatchManager now sends players to bidding scene
- Updated item scriptableobjects to use existing augments
- Merged playerInventory class with PlayerManager.
- Added new InputMap exclusive to bidding controls.
@Fueredoriku Fueredoriku linked an issue Nov 20, 2022 that may be closed by this pull request
@Fueredoriku Fueredoriku marked this pull request as ready for review November 21, 2022 18:19
Copy link
Collaborator

@toberge toberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for a temporary, nonfunctional version of the bidding scene. I've left a few comments.

Assets/Scripts/Gamestate/MatchController.cs Outdated Show resolved Hide resolved
Assets/Scripts/Gamestate/PlayerManager.cs Outdated Show resolved Hide resolved
Assets/Scripts/Gamestate/PodiumController.cs Outdated Show resolved Hide resolved
Assets/Scripts/Gamestate/PodiumController.cs Outdated Show resolved Hide resolved
@Fueredoriku Fueredoriku removed the request for review from Stektpotet November 22, 2022 14:45
@Fueredoriku Fueredoriku merged commit 8d7c56c into dev Nov 22, 2022
@Fueredoriku Fueredoriku deleted the feature/bidding-round branch November 22, 2022 14:46
@Stektpotet Stektpotet assigned Stektpotet and unassigned Stektpotet Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Movement rubberbanding Integrate bidding to match
3 participants