Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pause menu (now global) #759

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Add pause menu (now global) #759

merged 2 commits into from
Jul 8, 2024

Conversation

toberge
Copy link
Collaborator

@toberge toberge commented Jul 8, 2024 •
edited
Loading

  • Pause menu, accessible from fps round and bidding
  • Shown as global UI
  • Cleaned up return-to-main-menu code as everything is handled once you StopHost()
  • Fix loading screen starting multiple times (though only by preventing it from starting several times)

Closes #585 and #586

@toberge toberge marked this pull request as ready for review July 8, 2024 13:16
@toberge toberge mentioned this pull request Jul 8, 2024
Closed
CraZyB1336
CraZyB1336 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@CraZyB1336 CraZyB1336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me!

Works both in local and in multiplayer. Good base for future functions

@toberge toberge merged commit df94b54 into dev Jul 8, 2024
2 checks passed
@toberge toberge deleted the feature/pause-menu2 branch July 8, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CraZyB1336 CraZyB1336 CraZyB1336 approved these changes

@Fueredoriku Fueredoriku Awaiting requested review from Fueredoriku

Assignees
No one assigned
Labels
None yet
Projects
Prosjekt-Spill-H22 board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pause menu (that doesn't pause the game) accessible from shooting rounds (at least)
2 participants
@toberge @CraZyB1336