Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-occupying scenery #91

Merged
merged 5 commits into from
Mar 6, 2022
Merged

Conversation

ddabble
Copy link
Member

@ddabble ddabble commented Mar 4, 2022

Depends on #90; this PR should change base to develop automatically after #90 has been merged.

Main summary:

  • Enabled generating non-occupying scenery objects (3a2428f)
    • It would be quite frustrating if the map were littered with cells you're unable to build towers on, just because some grass is placed on them. This adds an extra GameObject list to HexGrid - nonOccupyingSceneryObjects - which places scenery objects without occupying the hex cells they're placed on.
    • HexGrid now generates the map with grass placed randomly
  • Moved scenery prefab objects to ground level (bbb1af2)
    • Now the rocks are no longer placed below ground ✨

See each commit message for additional changes and details.

Also renamed `HexGrid.sceneryObjects` -> `occupyingSceneryObjects`.
Previously, some of them were placed slightly below or above ground.
They should now be slightly narrower than a hex cell, which looks better when placed on the map.
Base automatically changed from fix/unigolem-spawning to develop March 6, 2022 19:02
@ddabble ddabble marked this pull request as ready for review March 6, 2022 19:46
Copy link
Collaborator

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, runs with no problems on my machine (tm)

@ddabble ddabble merged commit 81504b1 into develop Mar 6, 2022
@ddabble ddabble deleted the feature/non-occupying-scenery branch March 6, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants