Followers/Following not working

[PragTob]

Hey everybody,

clicking on the followers/following of a user gives you an error. I tried it with my account, a random account and Steve's account.

Can I access the error logs somehow? If I get to it I'll try to reproduce and fix it on my own machine today/tomorrow.

Tobi

[steveklabnik]

Uh oh.

Can I access the error logs somehow?

I'd have to give you Heroku access, which I'm not 100% against, but... can you reproduce it on your machine, maybe? If not, I'll try it and get you a log

[PragTob]

I'll try on my machine and hope that I can do it, if not I'll contact you :-)

However enjoy wroc_love.rb! =)

[PragTob]

So I fixed this, I took the liberty to introduce two css classes in order to make testing not such a pain :-)

I think that the root cause of this bug is that it is params[:id] or params[:user_id] whereas what's really in there is the username which lead to this wrong ORM query. Also I think it'd be nice if it would always be :user_id or :id or the resource helper method of the UsersController could be extended to handle both, like:

# current version
def resource
  @user ||= end_of_association_chain.find_by_username(params[:id])
end

# more flexible version
def resource
  @user ||= end_of_association_chain.find_by_username(params[:id] || params[:user_id])
end

Dunno if that would break anything though, if you want I could try that. But id's that are really usernames still hinders readability a bit in my eyes :-(

Tobi

[PragTob]

Oh yeah I closed this issue but I guess that the changes still have to be deployed :-)