Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add disabled logic, update classnames for buttons #1629

Merged
merged 5 commits into from May 17, 2024

Conversation

Spiteless
Copy link
Member

Fixes #1628

What changes did you make and why did you make them ?

  • Updated text on Create Profile button
  • Added disabled logic to check in button

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied image
Visuals after changes are applied image

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Spiteless-ts.login_buttons development
git pull https://github.com/Spiteless/VRMS.git ts.login_buttons

Copy link
Member

@lcchrty lcchrty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! App works as expect - there is a note that you may need to pull from development before merging!

@Spiteless Spiteless merged commit 617e52d into hackforla:development May 17, 2024
4 of 5 checks passed
@Spiteless Spiteless deleted the ts.login_buttons branch May 17, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update logic for disabled classes with Check in and "CREATE A NEW PROFILE" buttons
5 participants