-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Accessible and Reusable Modal Dialog Component and Refactor Existing Dialogs to Use It #1282
Comments
Please provide update Progress: "What is the current status of your project? What have you completed and what is left to do?" |
Progress: Two of eight modals replaced on my local repository. |
Progress: Four of eight modals replaced on my local repository. Modals have been modified to take in functions and open/close state as props from parent components. |
Progress: Removed two modals, bringing the total number of modals down to six. Three of which are completed. |
@Jonathanko52 Please provide an update. |
Progress: Added the ability for Modal to take components as props, which is used for some other modals in the project that have extensive text. Now working on The last two Modals, duplicate and delete project. |
Progress: "Duplicate" modal now able to make duplicates. I still have to add the ability to change titles. That aside, that leaves the "Delete" Modal |
Progress: Inapplicable, Navconfirm, DeleteProject, Duplicate, Terms and Conditions, and Checklist Modals replaced. Trap focus to Modal function added. |
Progress: Code cleanup. Enter now standardized to activate in-focus item. Colors added for delete, duplicate, and terms and conditions buttons |
@entrotech - Please review |
Overview
We need to use a common dialog component for implementing modal dialogs in the application in order to reduce duplicate code and ensure consistency in the look and feel of the various dialogs. Currently, there are several modal dialogs in the application, each of them implemented independently, with differing behavior and styles.
Action Items
Resources/Instructions
See https://medium.com/@seif_ghezala/how-to-create-an-accessible-react-modal-5b87e6a27503 for a good implementation.
Examples:
![image](https://user-images.githubusercontent.com/9939032/205175629-db191b8e-9a1a-4e8b-b225-e1362ed15f31.png)
Checklist Modal Dialog:
Leave the project Wizard Dialog:
![image](https://user-images.githubusercontent.com/9939032/205175826-4d778f92-9ceb-4fc9-8e4e-d0bf11492ec4.png)
Delete Project Dialog:
![image](https://user-images.githubusercontent.com/9939032/205175995-cd07c83e-afc9-4c71-8143-050264fb7663.png)
Terms and Conditions Dialog
![image](https://user-images.githubusercontent.com/9939032/205176164-7ad21d2e-9531-4cd9-9439-286251489854.png)
The text was updated successfully, but these errors were encountered: