Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolkit page: Hide suggest buttons #3678

Closed
4 tasks done
JessicaLucindaCheng opened this issue Oct 31, 2022 · 7 comments · Fixed by #3721
Closed
4 tasks done

Toolkit page: Hide suggest buttons #3678

JessicaLucindaCheng opened this issue Oct 31, 2022 · 7 comments · Fixed by #3721
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Milestone

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Oct 31, 2022

Overview

On the Toolkit page, we want to temporarily hide the currently non-functional Suggest a guide and Suggest a resource buttons so that visitors cannot select or click buttons on our website that do not function yet.

Details

We are hiding the buttons until we figure out how the buttons will function when they are clicked, such as where the buttons lead to.

Click here to see screenshots of the Suggest a resource and Suggest a guide buttons on the Toolkit page

Action Items

In pages/toolkit.html, using the hidden attribute

  • Hide the Suggest a guide button and add a comment about it by changing
            <button class="btn btn-primary btn-md-narrow">Suggest a guide</button>
    
    to
            <!-- The Suggest a guide button has been temporarily hidden until we figure out how this button will function after it's clicked. See issue #3678 for more details. -->
            <button hidden class="btn btn-primary btn-md-narrow">Suggest a guide</button>
    
  • Hide the Suggest a resource button and add a comment about it by changing
                    <button class="btn btn-primary btn-md-narrow">Suggest a resource</button>
    
    to
                    <!-- The Suggest a resource button has been temporarily hidden until we figure out how this button will function after it's clicked. See issue #3678 for more details. -->
                    <button hidden class="btn btn-primary btn-md-narrow">Suggest a resource</button>
    
  • Using developer tools, make sure both the buttons are not visible when you visit the Toolkit page in mobile, tablet, and desktop views
  • Using a screen reader, such as the Screen Reader Chrome Extension, make sure both the buttons are not read by the screen reader either

Resources/Instructions

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers Complexity: Medium P-Feature: Toolkit https://www.hackforla.org/toolkit/ size: 1pt Can be done in 4-6 hours Draft Issue is still in the process of being created labels Oct 31, 2022
@JessicaLucindaCheng JessicaLucindaCheng added this to New Issue Approval in Project Board via automation Oct 31, 2022
@JessicaLucindaCheng

This comment was marked as outdated.

@JessicaLucindaCheng

This comment was marked as outdated.

@JessicaLucindaCheng JessicaLucindaCheng added Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less and removed Complexity: Medium size: 1pt Can be done in 4-6 hours labels Nov 10, 2022
@JessicaLucindaCheng JessicaLucindaCheng added size: 0.25pt Can be done in 0.5 to 1.5 hours Ready for Prioritization and removed size: 0.5pt Can be done in 3 hours or less Draft Issue is still in the process of being created labels Nov 10, 2022
@ExperimentsInHonesty ExperimentsInHonesty added this to the 05. Know HFLA milestone Nov 13, 2022
@ExperimentsInHonesty ExperimentsInHonesty moved this from New Issue Approval to Prioritized backlog in Project Board Nov 13, 2022
@Skydodle Skydodle self-assigned this Nov 13, 2022
@Skydodle Skydodle moved this from Prioritized backlog to In progress (actively working) in Project Board Nov 13, 2022
@github-actions
Copy link

Hi @Skydodle, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@Skydodle
Copy link
Member

Availability: Wednesday, Saturday, Sunday

ETA : Sunday 11/20 by the end of day

Project Board automation moved this from In progress (actively working) to QA Nov 16, 2022
@ExperimentsInHonesty
Copy link
Member

Is this documented in the wiki?

@ExperimentsInHonesty ExperimentsInHonesty moved this from QA to Questions / In Review in Project Board Nov 27, 2022
@ExperimentsInHonesty
Copy link
Member

Document what happened in our wiki page for the Toolkit and then when the design gets relaunched we can decide how and where we are brining the buttons back.

@ExperimentsInHonesty ExperimentsInHonesty moved this from Questions / In Review to New Issue Approval in Project Board Nov 27, 2022
@ExperimentsInHonesty ExperimentsInHonesty added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Nov 27, 2022
@JessicaLucindaCheng
Copy link
Member Author

Document what happened in our wiki page for the Toolkit and then when the design gets relaunched we can decide how and where we are brining the buttons back.

@JessicaLucindaCheng JessicaLucindaCheng moved this from New Issue Approval to Done in Project Board Jan 24, 2023
@ExperimentsInHonesty ExperimentsInHonesty removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Archived in project
Project Board
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants