Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ER: Update labels not applied on Open Issues with Closed PR #4704

Closed
2 of 5 tasks
t-will-gillis opened this issue May 21, 2023 · 2 comments
Closed
2 of 5 tasks

ER: Update labels not applied on Open Issues with Closed PR #4704

t-will-gillis opened this issue May 21, 2023 · 2 comments
Labels
Bug Something isn't working Complexity: Medium ER Emergent Request Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Project Board
Milestone
08. Team workflow

Comments

@t-will-gillis
Copy link
Member

t-will-gillis commented May 21, 2023 •
edited
Loading

Emergent Requirement - Problem

Currently, when issues are linked to a PR, the bot no longer adds/ edits update labels (eg To Update ! and 2 weeks inactive). Normally this is not a problem since PRs get tracked well, but when a PR is closed this issue might no longer have any tracking.

Issue you discovered this emergent requirement in

Date discovered

  • 5/21/23

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@t-will-gillis

What happens if this is not addressed

There is the potential for the open issue to be untracked since the labels will no longer be updating.

Resources

add-label.js

Recommended Action Items

  • Make a new issue
  • Discuss with team: This is definitely an 'edge case' and this may not be worth the effort to fix?
  • Let a Team Lead know

Potential solutions [draft]
@t-will-gillis t-will-gillis added Draft Issue is still in the process of being created size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 21, 2023
@t-will-gillis t-will-gillis added this to New Issue Approval in Project Board via automation May 21, 2023
@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing labels May 21, 2023
@t-will-gillis t-will-gillis changed the title ER: Update labels not applied on issues ER: Update labels not applied on issues with linked but closed PR May 21, 2023
@TJameel120 TJameel120 mentioned this issue May 21, 2023
Closed
4 tasks
@t-will-gillis t-will-gillis changed the title ER: Update labels not applied on issues with linked but closed PR ER: Update labels not applied on Open Issues with Closed PR May 21, 2023
@t-will-gillis t-will-gillis added Bug Something isn't working Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers Complexity: Medium and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing labels May 21, 2023
@wanyuguan wanyuguan added this to the 08. Team workflow milestone May 28, 2023
@t-will-gillis t-will-gillis removed the Draft Issue is still in the process of being created label Jun 4, 2023
@t-will-gillis t-will-gillis moved this from New Issue Approval to Emergent Requests in Project Board Jun 4, 2023
@t-will-gillis t-will-gillis added role: dev leads Tasks for technical leads and/or merge team members ready for dev lead Issues that tech leads or merge team members need to follow up on and removed role: dev leads Tasks for technical leads and/or merge team members labels Jun 4, 2023
Open
2 tasks
@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Jun 13, 2023 •
edited
Loading

@t-will-gillis We are going to fix this edge case. So this ER can be turned into an issue

@t-will-gillis t-will-gillis mentioned this issue Jun 15, 2023
Closed
3 tasks
@t-will-gillis
Copy link
Member Author

Closing this ER: new issue created 4839.

Project Board automation moved this from Emergent Requests to QA Jun 15, 2023
@HackforLABot HackforLABot moved this from QA to Done in Project Board Jun 15, 2023
@kimberlytanyh kimberlytanyh added the ER Emergent Request label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Complexity: Medium ER Emergent Request Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
HfLA Website: Project Board
Archived in project
Project Board
  
Done
Milestone
08. Team workflow
Development

No branches or pull requests
4 participants
@wanyuguan @ExperimentsInHonesty @t-will-gillis @kimberlytanyh