Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magmom from previous run #275

Closed
fraricci opened this issue Mar 17, 2019 · 3 comments
Closed

Magmom from previous run #275

fraricci opened this issue Mar 17, 2019 · 3 comments

Comments

@fraricci
Copy link
Contributor

What pointed out here:

atomate/atomate/vasp/firetasks/write_inputs.py

Line 341 in a2cfee5

# TODO: @albalu - can magmom be auto-parsed from the previous calc? -computron

it might be solved now in:
materialsproject/pymatgen#1397
@fraricci fraricci mentioned this issue Mar 17, 2019
Closed
@fraricci
Copy link
Contributor Author

I think that now magmom can be an optional external parameter.

@mkhorton
Copy link
Contributor

mkhorton commented Mar 17, 2019 •
edited

Yes, the optional magmom parameter is a result of inheriting from DictSet.

@itsduowang
Copy link
Contributor

Since the problem is resolved, I will close this issue for now. Please let us know for any problems or concerns. Cheers! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mkhorton @fraricci @itsduowang