Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require minimum maggma version 0.39.0 #741

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Require minimum maggma version 0.39.0 #741

merged 2 commits into from
Feb 1, 2022

Conversation

janosh
Copy link
Member

@janosh janosh commented Jan 28, 2022

Closes #728.

@munrojm
Copy link

munrojm commented Jan 28, 2022

Came here to open this PR, thanks @janosh.

@janosh
Copy link
Member Author

janosh commented Jan 28, 2022

Will try to update the code base for pymongo 4 compatibility tomorrow.

@janosh
Copy link
Member Author

janosh commented Jan 29, 2022

Ready for review.

@itsduowang itsduowang merged commit ebb6dc7 into hackingmaterials:main Feb 1, 2022
@itsduowang
Copy link
Contributor

Thanks @janosh for your contribution! I merged this PR.
Please let me know for any further problems or concerns. Cheers:)

@janosh janosh deleted the fix-m1-install branch February 1, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

M1 Mac incompatible
3 participants
@janosh @munrojm @itsduowang