Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featurize changes #69

Merged
merged 6 commits into from Sep 15, 2018
Merged

Featurize changes #69

merged 6 commits into from Sep 15, 2018

Conversation

ardunn
Copy link
Contributor

@ardunn ardunn commented Sep 15, 2018

Added logger
Refactored featurize_columns to auto_featurize
Prevent missing df keys from failing auto_featurize (just warn via logger)

@ardunn
Copy link
Contributor Author

ardunn commented Sep 15, 2018

@albalu pls merge if you are ok with these changes

@albalu
Copy link
Contributor

albalu commented Sep 15, 2018

It all looks good. I'll merge once the tests are passed.

As a side note, what's stopping us from getting rid of MultipleFeaturizer other than the fact that it is in the paper? It is causing too much hassle in my opinion. Anyone can write a for loop over their list of featurizers and featurize_dataframe that way no?

@ardunn
Copy link
Contributor Author

ardunn commented Sep 15, 2018

@albalu Nothing is stopping us! I liked the simplicity of MultipleFeaturizer but with the caching stuff added it fails a decent amount and the pbar doesn't work right (ie, each featurizer doesn't get its own pbar) so I rarely use it now.

@ardunn ardunn merged commit e4c81a8 into hackingmaterials:master Sep 15, 2018
@ardunn
Copy link
Contributor Author

ardunn commented Sep 15, 2018

@albalu I am just going to merge now cuz it is passing tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants