add marker outline option to scatter matrix

[computron]

No description provided.

[saurabh02]

This is added as an optional argument now (see 41ac9ad). The option currently also adds outline to histograms when chosen as diagonal.

[shyuep]

In general, I would suggest avoiding adding more and more options. Since FigRecipes is essentially a wrapper around matplotlib, you should just add a **kwargs option and pass-through all these to the plot function. That will make sure that you support ALL matplotlib supported kwargs, for now and for the future.

If you want to see how this philosophy is implemented, see the new VaspInputSets.

[shyuep]

Another simpler example is how the monty.io.zopen work.

[computron]

A couple of notes

1 - this is for plotly not matplotlib
2 - FigRecipes is not trying to add any extra functionality to the
underlying libraries, only make them more convenient to use. e.g. for
plotly make it so you don't have to memorize the underlying JSON object. in
this way it is more similar to the "cufflinks" library than anything else

That said, we'll see how much FigRecipes develops. So far I have found it
pretty useful and an easier learning curve from an operational standpoint
than the underlying plotting libraries, but it will be hard to retain this
as you need more complex plots.

On Mon, Nov 14, 2016 at 3:14 PM, Shyue Ping Ong notifications@github.com
wrote:

Another simpler example is how the monty.io.zopen work.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA8Oh130VdGRGVQ6hr33gNZwLrQ8WTAwks5q-OtjgaJpZM4Koq2N
.

Best,
Anubhav