Configure notifications by type #422
Conversation
|
BTW haven't yet soft-deprecated the |
|
Hi @dideler , it's my bad to forget mentioning the I like your approach to distinguish success and failure notification and their configurations. We can deprecate the |
|
Hey @hackjutsu, I'll go ahead and remove I noticed there's already a project wiki, but I don't have permissions to edit it. In order to document the config changes, could you either change the wiki permissions, or alternatively, we can move the config docs somewhere in the code repo and then I won't be blocked. |
|
@dideler The wiki permission is updated. Let me if it works. |
The previous setting "disableNotification" isn't extendable. There's no hierarchy to group notification settings. New notification settings would end up as a top-level config, which isn't consistent with existing configuration structure.
By classifying the type of notification, we can treat them differently. For now it's only whether to show the notification type, but in the future can also do things such as styling, formatting, content, etc.
dideler
force-pushed
the
configure-notifications-by-type
branch
from
5c291de
to
557a160
Compare
|
@hackjutsu wonderful, thank you! I've created a wiki page, moved over the existing content, added missing options, added the new I think this merge request is good to go now. |
|
Cool, thanks for the contribution! |
I have most notifications on all my devices reduced to a minimum. To reduce notification fatigue, I'm only interested in important notifications. For Lepton, I'm only interested in exceptional notifications, i.e. where the expected result hasn't occurred. I think it's especially important for macOS because these notifications cannot be force closed.
Tasks
disableNotificationoption