New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated macros to new rust plugin framework #65

Merged
merged 2 commits into from Jun 13, 2014

Conversation

Projects
None yet
3 participants
@farcaller
Member

farcaller commented Jun 12, 2014

This fixes recent compilation failures in master.

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Jun 12, 2014

Are the failing tests failing for the right reasons?

@farcaller

This comment has been minimized.

Member

farcaller commented Jun 12, 2014

If you mean stm32f4 — I have no idea what's happening inside there, actually, it was this way for quite a some time now. That's a rust/llvm bug though, which should be filed in as appropriate.

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Jun 12, 2014

I mean the lpc. At the bottom of the build log are errors about crate
resolution.

@farcaller

This comment has been minimized.

Member

farcaller commented Jun 12, 2014

facepalm

@bharrisau

This comment has been minimized.

bharrisau commented on 5a1ab05 Jun 13, 2014

r+

@hacknbot

This comment has been minimized.

Contributor

hacknbot commented on 5a1ab05 Jun 13, 2014

saw approval from bharrisau
at farcaller@5a1ab05

This comment has been minimized.

Contributor

hacknbot replied Jun 13, 2014

merging farcaller/zinc/plugin_registrar = 5a1ab05 into auto

This comment has been minimized.

Contributor

hacknbot replied Jun 13, 2014

farcaller/zinc/plugin_registrar = 5a1ab05 merged ok, testing candidate = 1ebfea6

This comment has been minimized.

Contributor

hacknbot replied Jun 13, 2014

This comment has been minimized.

Contributor

hacknbot replied Jun 13, 2014

fast-forwarding master to auto = 1ebfea6

hacknbot added a commit that referenced this pull request Jun 13, 2014

Merge pull request #65 from farcaller/plugin_registrar
Updated macros to new rust plugin framework

Reviewed-by: bharrisau

@hacknbot hacknbot merged commit 5a1ab05 into hackndev:master Jun 13, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default all tests passed
Details

@farcaller farcaller deleted the farcaller:plugin_registrar branch Jun 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment