Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect logic in bus / rail classification #18

Closed
znmeb opened this issue Jun 15, 2019 · 2 comments
Closed

Incorrect logic in bus / rail classification #18

znmeb opened this issue Jun 15, 2019 · 2 comments
Assignees
@znmeb
Labels
bug Something isn't working
Projects
HackOregon 2019 cycle

Comments

@znmeb
Copy link
Contributor

znmeb commented Jun 15, 2019

The scheme I used to distinguish bus from rail in the "stop event" files is wrong. I'm using service_key, which doesn't give the right answer. The correct way is to have a route number table.
@znmeb znmeb self-assigned this Jun 15, 2019
@znmeb znmeb added the bug Something isn't working label Jun 15, 2019
@znmeb znmeb mentioned this issue Jun 15, 2019
Closed
@znmeb
Copy link
Contributor Author

znmeb commented Jun 15, 2019

Depends on TriMet GIS data - code to insert that is done.

znmeb added a commit that referenced this issue Jun 15, 2019
@znmeb
untested fixes for issue #18
2dac570
znmeb added a commit that referenced this issue Jun 16, 2019
@znmeb
fixed #18 for buses
2315c0b
znmeb added a commit that referenced this issue Jun 16, 2019
@znmeb
rail fixes for #18
fab5a22
@znmeb
Copy link
Contributor Author

znmeb commented Jun 18, 2019

This is fixed in the latest database - it turns out there are some inconsistencies in the "service_key" field for rail data so I'm ignoring it for rail data. I still need to check for the same thing in bus data.

@znmeb znmeb added this to In progress in HackOregon 2019 cycle Jun 22, 2019
@znmeb znmeb moved this from In progress to Done in HackOregon 2019 cycle Jun 22, 2019
@znmeb znmeb closed this as completed Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@znmeb znmeb

Labels
bug Something isn't working
Projects
HackOregon 2019 cycle
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@znmeb