New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential timing attack #2

Closed

TechSupportJosh opened this issue May 2, 2023 · 0 comments · Fixed by #3

Assignees

Labels

security

TechSupportJosh commented May 2, 2023

And by potential, I do mean potential :) Should use timing safe comparison here

Hackster/src/webhooks/server.py

Line 43 in ff719da

if not token == settings.WEBHOOK_TOKEN:

dimoschi added the security label

dimoschi linked a pull request

that will close this issue

Refactor webhook authorization in server.py using hmac #3

Merged

7 tasks

makelarisjr closed this as completed in #3

dimoschi self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment