Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Utils):🦺 Add New Function to Verify Account #406

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lleung030
Copy link
Contributor

@lleung030 lleung030 commented Dec 5, 2023

Status

Ready

Description

Added a function

  • Checks if user's account exists

@lleung030 lleung030 changed the title feat(Utils): ✨ Add New Function to Verify Account feat(Utils): 🦺 Add New Function to Verify Account Dec 5, 2023
@lleung030 lleung030 changed the title feat(Utils): 🦺 Add New Function to Verify Account feat(Utils):🦺 Add New Function to Verify Account Dec 5, 2023
@lleung030 lleung030 force-pushed the features/gravatar-confirm-setup branch from 05b7de1 to 1e70d18 Compare December 5, 2023 22:54
lib/gravatar/utils.py Show resolved Hide resolved
@lleung030 lleung030 force-pushed the features/gravatar-confirm-setup branch from 8de78fc to 0e5d804 Compare December 6, 2023 18:02
Copy link
Member

@jontsai jontsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would be nicer if you either added unit tests, or added a transcript from the Python REPL in the PR description demonstrating the new utility function.

Changed naming from _get to _build
Changed response status_code to 200
Imported requests
@lleung030 lleung030 force-pushed the features/gravatar-confirm-setup branch from a5207dd to 0f5fc5d Compare December 6, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants