Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation in bytecode mode #55

Merged
merged 1 commit into from Jan 10, 2024
Merged

Conversation

mseri
Copy link
Contributor

@mseri mseri commented Jan 10, 2024

This should solve the issue in ocaml/opam-repository#25033

@hackwaly
Copy link
Owner

I merged it. /cc @sim642

@hackwaly hackwaly merged commit 285c130 into hackwaly:master Jan 10, 2024
@sim642 sim642 added the bug Something isn't working label Jan 10, 2024
@mseri mseri deleted the patch-1 branch January 10, 2024 22:18
@mseri
Copy link
Contributor Author

mseri commented Jan 10, 2024

Do you want to update the release or I can merge that with the conflict with bytecode compiler?

@hackwaly
Copy link
Owner

hackwaly commented Jan 11, 2024

Do you want to update the release or I can merge that with the conflict with bytecode compiler?

Thank you! Your patch could be released with next release. I don't know how to update the release. Is it close the PR on opam repository and re-release the same version with your patch?

@sim642
Copy link
Collaborator

sim642 commented Jan 11, 2024

It shouldn't be the same release because 1.3.0 is already in our GitHub releases etc. I can release 1.3.1 with this soon too.

@hackwaly
Copy link
Owner

It shouldn't be the same release because 1.3.0 is already in our GitHub releases etc. I can release 1.3.1 with this soon too.

Could you release 1.3.1? I've already forgotten how to use dune-release.

sim642 added a commit to sim642/opam-repository that referenced this pull request Jan 11, 2024
CHANGES:

### Fixed

* Fix bytecode-only installation (hackwaly/ocamlearlybird#55).
@sim642
Copy link
Collaborator

sim642 commented Jan 11, 2024

This doesn't seem to really help: ocaml/opam-repository#25063 fails with

#=== ERROR while compiling earlybird.1.3.1 ====================================#
# context              2.2.0~alpha4~dev | linux/arm32 | ocaml-base-compiler.5.1.1 | pinned(https://github.com/hackwaly/ocamlearlybird/releases/download/1.3.1/earlybird-1.3.1.tbz)
# path                 ~/.opam/5.1/.opam-switch/build/earlybird.1.3.1
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p earlybird -j 79 @install
# exit-code            1
# env-file             ~/.opam/log/earlybird-7-2e1bf8.env
# output-file          ~/.opam/log/earlybird-7-2e1bf8.out
### output ###
# File "src/main/dune", line 3, characters 7-11:
# 3 |  (name main)
#            ^^^^
# Error: No rule found for src/main/main.exe

It's the same problem, just from a slightly different place.

@mseri
Copy link
Contributor Author

mseri commented Jan 11, 2024

Mmh, very strange. I'll try to look into it. Unfortunately I cannot do it for some time still.

@sim642
Copy link
Collaborator

sim642 commented Jan 12, 2024

I suspect the reason is this line:

(modes byte native)

In dune's linking modes, this demands both native and bytecode binaries, but that might not be necessary. The default exe might already do the right thing: produce an exe, which might be native or which might be a bytecode one.

sim642 added a commit that referenced this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants