Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: expose type of selection via openapi #1050

Closed
wants to merge 2 commits into from
Closed

feat!: expose type of selection via openapi #1050

wants to merge 2 commits into from

Commits on Jun 7, 2023

  1. feat: expose type of current selection via OpenAPI 

    This adds a new endpoint to the OpenAPI, but does not change any
existing endpoints.

Signed-off-by: Ben Price <ben@hackworthltd.com>
    @brprice @dhess
    brprice authored and dhess committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    debdc30 View commit details
    Browse the repository at this point in the history

  2. fix: work around an OpenAPI 3.0 spec issue regarding nullable results 

    This fixes an issue where the OpenAPI schema check failed when
`setSelection` returns `Nothing`. This should never happen in theory
and is just a quirk of our typechecker implementation, but our OpenAPI
adapter can't properly handle this scenario, and the OpenAPI 3.0 spec
isn't clear how to do so, either.

To work around this, we add a wrapped version of `setSelection` that
converts `Nothing` results to an API error.

Signed-off-by: Drew Hess <src@drewhess.com>
    @dhess
    dhess committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    2885106 View commit details
    Browse the repository at this point in the history