Uid is required to switch netns #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udzura
reviewed
Jan 27, 2017
| flag = base.namespace.to_flag & (~(::Namespace::CLONE_NEWPID)) | ||
| ::Namespace.setns(flag, pid: base.pid) | ||
| flag = base.namespace.to_flag_without_pid_and_user | ||
| ::Namespace.setns(flag, pid: base.pi:) |
|
I wander what is the difference... This would |
|
This PR is including cgroupv2 diff (#69). Can you rebase to current master and force-push it? |
pyama86
force-pushed
the
fix-net-ns
branch
2 times, most recently
from
2580f01
to
1dab28a
Compare
udzura
added a commit
that referenced
this pull request
Jan 27, 2017
udzura
added a commit
that referenced
this pull request
Jan 27, 2017
Backport setns timing issue from #70
udzura
added a commit
that referenced
this pull request
Apr 13, 2017
Uid is required to switch netns
udzura
added a commit
that referenced
this pull request
Apr 13, 2017
udzura
added a commit
that referenced
this pull request
Apr 13, 2017
Backport setns timing issue from #70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi!
Fixed as netns did not work when attach command haconiwa
Always next to you!!