Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomic7777/atomic_calendar #377

Closed
marksie1988 opened this issue Apr 30, 2020 · 8 comments
Closed

atomic7777/atomic_calendar #377

marksie1988 opened this issue Apr 30, 2020 · 8 comments
Assignees

Comments

@marksie1988
Copy link
Contributor

Describe why you are flagging this

This repository is dead and hasn't been updated, it no longer works with the latest HA.

I have setup a new version here which is being maintained:
https://github.com/marksie1988/atomic_calendar_revive

This template should only be used if a repository needs to be removed/blacklisted from HACS

@hacs-bot
Copy link

hacs-bot bot commented Apr 30, 2020

Make sure you have read the issue guidelines and that you filled out the entire template.

@maxwroc
Copy link
Contributor

maxwroc commented Apr 30, 2020

@marksie1988 I'm on 0.109.1 (latest HA) and atomic_calendar works fine so I don't see a reason for blacklisting it (especially that yours is not available on HACS default)

@marksie1988
Copy link
Contributor Author

@maxwroc thats interesting as the reason for moving to the new version was because it stopped working with HA at version 106.

I created this "revive" version as the current version is no longer developed and there have been no merges of PRs for quite some time. I merged all the PRs and have added more features on top

The reason I supplied the new repo is that this could be added to HACS natively instead of the original which is no longer developed.

@UbhiTS
Copy link
Contributor

UbhiTS commented Apr 30, 2020

I'm on HA 109 and the atomic calendar is working perfectly. I'm unable to realy see the difference. I think this would confuse the users which one to install since they are both practically the same.

@UbhiTS
Copy link
Contributor

UbhiTS commented Apr 30, 2020

I just posted a question on the original repo asking the developer if he's still actively maintaining the atomic calendar. Hopefully he or she will answer soon.

@maxwroc
Copy link
Contributor

maxwroc commented Apr 30, 2020

I'm on HA 109 and the atomic calendar is working perfectly. I'm unable to realy see the difference. I think this would confuse the users which one to install since they are both practically the same.

I second that. @marksie1988 Can you clearly highlight in the README what was added/fixed in your fork (maybe in additional designated section). This way people can easily decide whether thay want to use your card or the original one.

BTW thanks for taking over this project, I use this card for a long time and wanted to do some UI changes/adjustments so I'm going to add a feature request and maybe send PR some time in the future

@marksie1988
Copy link
Contributor Author

@maxwroc happy to update the readme with the differences.

Interesting that it works with 109, I'm guessing the issue that was seen in the card was rolled back in the new HA version.

@ludeeus
Copy link
Member

ludeeus commented May 1, 2020

By the looks of this issue, it sounds like it's still working, so blacklisting it will be overkill.
If that changes I'll be happy to remove it, the author has not done anything on github since september so I doubt that will change now.
But since it's stil working, I'll close this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants