Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new integration [speleolontra/daikin_residential_altherma] #1799

Merged
merged 15 commits into from
Oct 8, 2023

Conversation

jwillemsen
Copy link
Contributor

@jwillemsen jwillemsen commented Mar 16, 2023

Checklist

  • I've read the publishing documentation.
  • I've added the HACS action to my repository.
  • (For integrations only) I've added the hassfest action to my repository.
  • The actions are passing without any disabled checks in my repository.
  • I've added a link to the action run on my repository below in the links section.
  • I've created a new release of the repository after the validation actions were run successfully.

Links

Link to current release: https://github.com/speleolontra/daikin_residential_altherma/releases/tag/v2.7.2
Link to successful HACS action (without the ignore key): https://github.com/speleolontra/daikin_residential_altherma/actions/runs/4912609136/jobs/8771817825
Link to successful hassfest action (if integration): https://github.com/speleolontra/daikin_residential_altherma/actions/runs/4912609557/jobs/8771818752

@ludeeus ludeeus marked this pull request as draft May 7, 2023 19:36
@jwillemsen jwillemsen marked this pull request as ready for review May 8, 2023 07:30
@jwillemsen
Copy link
Contributor Author

Updated to v2.7.2 release which has again green CI jobs

@ludeeus ludeeus marked this pull request as draft October 1, 2023 11:55
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing

@jwillemsen
Copy link
Contributor Author

Thanks @ludeeus, looks hassfest got stricter after I made this PR, where can I find documentation about this error, looks I have to add some translation for a service.

@ludeeus
Copy link
Member

ludeeus commented Oct 3, 2023

It's probably on HA dev docs or HA discord.

@jwillemsen
Copy link
Contributor Author

Ok, fixed as far as the CI on the integration itself shows.

@jwillemsen jwillemsen marked this pull request as ready for review October 3, 2023 08:39
@ludeeus ludeeus merged commit 2931e10 into hacs:master Oct 8, 2023
7 checks passed
@hacs-bot
Copy link

hacs-bot bot commented Oct 8, 2023

Your repository is now added to HACS 🎉
Here is a few resources that can be useful:

@jwillemsen jwillemsen deleted the patch-1 branch October 9, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants