Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only unload if loaded #1245

Merged
merged 1 commit into from May 24, 2020
Merged

Only unload if loaded #1245

merged 1 commit into from May 24, 2020

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented May 24, 2020

Closes #1244

@codecov
Copy link

codecov bot commented May 24, 2020

Codecov Report

Merging #1245 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
- Coverage   57.51%   57.48%   -0.03%     
==========================================
  Files          38       38              
  Lines        2210     2211       +1     
==========================================
  Hits         1271     1271              
- Misses        939      940       +1     
Impacted Files Coverage Δ
custom_components/hacs/__init__.py 17.12% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f448c35...2fa4ce5. Read the comment docs.

@ludeeus ludeeus merged commit f5cd407 into master May 24, 2020
@ludeeus ludeeus deleted the sensor-unload branch July 8, 2020 14:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the github ratelimit is hit a forward entry unload is done for sensor but it was never loaded.
1 participant