-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc PR: core extraction features, traits, generic improvements... #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50a6bbd
to
9d57ea2
Compare
61ee937
to
8313546
Compare
8f43a58
to
7f8fb0b
Compare
This commit adds a `capture` primitive in `Diagnostics.ml`. `capture` can run a function without reporting directly errors, instead returning the errors as data. Dep. analysis occurs on Hax's internal AST. Thus, we need to import items first. But we don't support importing everything. Errors occuring on import should thus be delayed and displayed only when they are about items we actually want to extract. That's what this commit does with `capture`.
franziskuskiefer
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in.
Just add something in a readme for that one nit.
This was referenced Oct 13, 2023
This was referenced Dec 20, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bit unfortunate, it's packing a huge number of interleaved features...
However, each the (basic) CI is green on each and every commit, and I extensively cleaned up the history, so things should not be too much messed up.
Previous description: