Add Self implsource
#372
Merged
Add Self implsource
#372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W95Psp
force-pushed
the
add-self-implsource
branch
2 times, most recently
from
47cb709
to
aea38f2
Compare
franziskuskiefer
approved these changes
Nov 24, 2023
franziskuskiefer
requested changes
Nov 29, 2023
W95Psp
force-pushed
the
add-self-implsource
branch
4 times, most recently
from
68b5719
to
4a4249d
Compare
W95Psp
force-pushed
the
add-self-implsource
branch
from
4a4249d
to
9272888
Compare
Re-introduce `try_normalize_erasing_regions`, but only when we compare two predicate for equality: Rust consider two instance to be overlapping if they differ only in terms of lifetime, thus while trait resolution, this information is useless. Worse, in some situation, two predicates can end up different solely because of lifetimes.
W95Psp
force-pushed
the
add-self-implsource
branch
from
9272888
to
a7463f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370
This PR:
Selfkind forImplSource. This is useful for generic information within a trait.implon function calls.Fixes #20
Note: this PR failing is blocking for @cmester0's #349 and #348.
Since this is a bit urgent, my plan is to make failure silent for now: any backend that relies on this feature will then possibly generate bad code if we hit the edge case that currently makes this PR fails.