Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use old behaviour when root.autorun=false #412

Merged
merged 2 commits into from Aug 21, 2022

Conversation

YegorStepanov
Copy link
Contributor

Breaking change has been added here.

Before breaking commit:

Scene.AutoRun=true:
  Awake
  Root.Configure
  Scene.Configure
  Awake end
Scene.AutoRun=false:
  Awake
  Root.Configure
  Awake end

After breaking commit:

Scene.AutoRun=true:
  Root.Configure
  Awake
  Scene.Configure
  Awake end
Scene.AutoRun=false:
  Root.Configure
  Awake
  Awake end

This PR reverts the old behaviour, when Root.AutoRun=false (Currently Root.AutoRun is not used)

I'd say that is more correctly and it requires to me:
I'm using async LifetimeScopes to preload Addressables, so I need to await Awake (via the first SceneScope, because Awake is not called on Prefab)

The public autoRun is useful for me too, currently I get these values via Reflection.

@vercel
Copy link

vercel bot commented Aug 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
vcontainer ✅ Ready (Inspect) Visit Preview Aug 20, 2022 at 10:28PM (UTC)

@hadashiA
Copy link
Owner

👍

@hadashiA hadashiA merged commit 5adca25 into hadashiA:master Aug 21, 2022
@YegorStepanov YegorStepanov deleted the root-autorun branch August 24, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants