Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase visibility of RegistrationBuilder and InjectorCache to make VContainer more extensible. #564

Merged
merged 1 commit into from Jan 3, 2024

Conversation

pnarimani
Copy link
Contributor

@pnarimani pnarimani commented Oct 30, 2023

With members of RegistrationBuilder being internal, it's very difficult to create your own project-specific registrations.

I increased visiblity of members inside RegistrationBuilder to protected internal. This should allow classes that inherit from RegistrationBuilder to have access to those fields.

I also changed the visibility of InjectorCache to public. This is needed for the cases that a custom RegistrationBuilder needs to be made.

This will allow users to create project specific registration and tailor VContainer to their own needs.
@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vcontainer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 7:30pm

@hadashiA
Copy link
Owner

hadashiA commented Jan 3, 2024

I too have been having problems with extensibility lately. Thanks.
I'll fix the namespace later.

@hadashiA hadashiA merged commit 2c62055 into hadashiA:master Jan 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants