-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ensemble support for docking in CNS-based modules #152
Conversation
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
==========================================
- Coverage 39.14% 38.86% -0.29%
==========================================
Files 39 39
Lines 2174 2195 +21
==========================================
+ Hits 851 853 +2
- Misses 1323 1342 +19
Continue to review full report at Codecov.
|
You did upgrade |
topoaa -> flexref was anyway not working since flexref expects a PDB containing all molecules…
Did not check what you changed, but one way around this would be to actually create already in topoaa the starting complexes (as done in haddock2.4) rather than loading the individual PDB files into the sampling stage. But this might not be handy for third party sampling software.
An alternative would be to add a new module to create the starting complexes by combination of input PDB files.
Note that for this to work I had to change the data structure of topoaa, meaning that all modules that come after it need to be refactored, meaning meaning that we can no longer do refinement runs (but I'm not sure if this was possible anyway topoaa > flexref), let's work on this example in another PR.
Can you explain in a nutshell the difference in the structure of topoaa?
|
mdref is on my todo list - currently broken at probably both the python and CNS levels
|
Good suggestions, lets look into this when we implement refinement workflows.
Say Before, [PDBObject, PDBObject, PDBObject] And now it outputs a dictionary {0: [PDBObject], 1: [PDBObject, PDBObject]} So the modules that are loading from it need to handle the "multiple-objects-per-molecule" logic instead of simply reading a list. |
These work already! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda like that dict structure. Seems very versatile for what we need, present and future.
This PR implements ensemble support for docking and closes #148.
Note that for this to work I had to change the data structure of
topoaa
, meaning that all modules that come after it need to be refactored, meaning meaning that we can no longer do refinement runs (but I'm not sure if this was possible anywaytopoaa > flexref
), let's work on this example in another PR.