Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validates module's name #246

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Validates module's name #246

merged 1 commit into from
Jan 3, 2022

Conversation

joaomcteixeira
Copy link
Member

Reimplements a function that was silently disabled by #219.

Validates module's names after reading the configuration file.

@joaomcteixeira joaomcteixeira added the bug Something isn't working label Jan 3, 2022
@joaomcteixeira joaomcteixeira added this to the v3.0.0 stable release milestone Jan 3, 2022
@joaomcteixeira joaomcteixeira self-assigned this Jan 3, 2022
@joaomcteixeira joaomcteixeira added this to Needs triage in Bugs via automation Jan 3, 2022
@joaomcteixeira joaomcteixeira moved this from Needs triage to High priority in Bugs Jan 3, 2022
@joaomcteixeira joaomcteixeira moved this from High priority to In progress in Bugs Jan 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2022

Codecov Report

Merging #246 (3eda188) into main (7d621ba) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   55.15%   55.15%           
=======================================
  Files          48       48           
  Lines        2990     2990           
=======================================
  Hits         1649     1649           
  Misses       1341     1341           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d621ba...3eda188. Read the comment docs.

@joaomcteixeira joaomcteixeira merged commit 7268b4e into main Jan 3, 2022
Bugs automation moved this from In progress to Closed Jan 3, 2022
@joaomcteixeira joaomcteixeira deleted the check_module_name branch January 3, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Bugs
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants