Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions #25

Merged
merged 4 commits into from
Jul 19, 2021

Conversation

joaomcteixeira
Copy link
Member

Updates installation instructions after #21:

  • updates commands to new main branch name
  • more general cns executable name
  • adds conda yml
  • facilitates source env

* created yml file for conda
* updated installation steps
@joaomcteixeira joaomcteixeira added the enhancement Enhancing an existing feature of adding a new one label Jul 16, 2021
@joaomcteixeira joaomcteixeira self-assigned this Jul 16, 2021
@joaomcteixeira joaomcteixeira added this to In Progress in Documentation via automation Jul 16, 2021
bin/activate_haddock Outdated Show resolved Hide resolved
Copy link
Member

@rvhonorato rvhonorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still think we should remove lightdock from the dependencies; will all the supported modules be part of dependencies? what if next we add PatchDock, maybe ZDOCK, or even GROMACS, do they also needs to be installed so that you can run haddock? I don't think it makes much sense, but up to you.

@amjjbonvin
Copy link
Member

amjjbonvin commented Jul 17, 2021 via email

@joaomcteixeira
Copy link
Member Author

I understand your point. Well, at the current state those questions are difficult to answer in my opinion. But I understand your point. I will set lightdock as an optional dependency in another pull request and create the infrastructure to accommodate other optional dependencies as well. But I won't change them now in this PR not to mix too many things. 👍

@joaomcteixeira joaomcteixeira merged commit 667689b into haddocking:main Jul 19, 2021
Documentation automation moved this from In Progress to Done Jul 19, 2021
@joaomcteixeira joaomcteixeira deleted the install_instructions branch July 19, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancing an existing feature of adding a new one
Projects
Documentation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants