Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renames flavour to mode missing files #26

Merged
merged 1 commit into from
Jul 16, 2021
Merged

renames flavour to mode missing files #26

merged 1 commit into from
Jul 16, 2021

Conversation

joaomcteixeira
Copy link
Member

Some names flavour remained after #21. This broke any runs where flavour was not the default, for example in lightdock.

@joaomcteixeira
renames flavour to mode
161b7cc 
Some names `flavour` remained after haddocking#21. This broke any runs where flavour
was not the "default", for example in lightdock.
@joaomcteixeira joaomcteixeira added the bug Something isn't working label Jul 16, 2021
@joaomcteixeira joaomcteixeira self-assigned this Jul 16, 2021
@joaomcteixeira joaomcteixeira added this to Needs triage in Bugs via automation Jul 16, 2021
@joaomcteixeira joaomcteixeira mentioned this pull request Jul 16, 2021
Closed
@joaomcteixeira joaomcteixeira changed the title renames flavour to mode renames flavour to mode missing files Jul 16, 2021
rvhonorato
rvhonorato approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@rvhonorato rvhonorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed a few :)

@joaomcteixeira joaomcteixeira moved this from Needs triage to High priority in Bugs Jul 16, 2021
@joaomcteixeira joaomcteixeira merged commit ad529fe into haddocking:main Jul 16, 2021
Bugs automation moved this from High priority to Closed Jul 16, 2021
@joaomcteixeira joaomcteixeira deleted the flavour_to_mode branch July 16, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvhonorato rvhonorato rvhonorato approved these changes

@brianjimenez brianjimenez Awaiting requested review from brianjimenez

@amjjbonvin amjjbonvin Awaiting requested review from amjjbonvin

Assignees

@joaomcteixeira joaomcteixeira

Labels
bug Something isn't working
Projects
Bugs
  
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joaomcteixeira @rvhonorato