Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove missing PDBs from ModuleIO #313

Merged
merged 4 commits into from
Feb 10, 2022
Merged

Remove missing PDBs from ModuleIO #313

merged 4 commits into from
Feb 10, 2022

Conversation

joaomcteixeira
Copy link
Member

Closes #307

Removes missing PDBs from ModuleIO when checking the fauly.

@joaomcteixeira joaomcteixeira added the bug Something isn't working label Feb 10, 2022
@joaomcteixeira joaomcteixeira self-assigned this Feb 10, 2022
@joaomcteixeira
Copy link
Member Author

@amjjbonvin can you test it to see if the #307 error persists?

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #313 (2db63e5) into main (a2e471c) will decrease coverage by 0.14%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
- Coverage   56.18%   56.04%   -0.15%     
==========================================
  Files          56       56              
  Lines        3540     3551      +11     
==========================================
+ Hits         1989     1990       +1     
- Misses       1551     1561      +10     
Impacted Files Coverage Δ
src/haddock/libs/libontology.py 41.12% <8.33%> (-3.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e471c...2db63e5. Read the comment docs.

@amjjbonvin amjjbonvin merged commit 03ac30e into main Feb 10, 2022
@amjjbonvin amjjbonvin deleted the 307 branch February 10, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libontology wrongly keeps models that are not present
4 participants