Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix % display in libhpc #360

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Fix % display in libhpc #360

merged 1 commit into from
Mar 7, 2022

Conversation

rvhonorato
Copy link
Member

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:

  • You have stick to Python. Talk with us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there's a (state) purpose
  • code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any install dependencies unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 馃敟
  • Your PR is about writing tests for already existing code :godmode:

Fix #358

@rvhonorato rvhonorato self-assigned this Mar 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022

Codecov Report

Merging #360 (57935c0) into main (850cf65) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   61.41%   61.45%   +0.04%     
==========================================
  Files          65       65              
  Lines        4266     4263       -3     
==========================================
  Hits         2620     2620              
+ Misses       1646     1643       -3     
Impacted Files Coverage 螖
src/haddock/libs/libhpc.py 21.01% <0.00%> (+0.44%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 850cf65...57935c0. Read the comment docs.

Copy link
Member

@amjjbonvin amjjbonvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - so the reported percentages are now from the currently running jobs (i.e. in the worker list) and not the total number of requested models, correct?

@joaomcteixeira joaomcteixeira added the bug Something isn't working label Mar 7, 2022
@joaomcteixeira joaomcteixeira added this to Needs triage in Bugs via automation Mar 7, 2022
@rvhonorato
Copy link
Member Author

It is reported now by batch (with then depends on the queue_limit)

[2022-03-07 12:16:01,865 libhpc INFO] Concatenating, each .job will produce 5 (or less) models
[2022-03-07 12:16:01,865 libhpc INFO] > Running batch 1/1
[2022-03-07 12:16:01,910 libhpc INFO] >> topoaa_1.job submitted
[2022-03-07 12:16:01,911 libhpc INFO] >> Waiting... (10.00s)
[2022-03-07 12:16:11,943 libhpc INFO] >> Batch 1/1 took 10.08s to finish, 100.00% complete
...
2022-03-07 12:16:57,370 libhpc INFO] >> rigidbody_99.job running
[2022-03-07 12:16:57,395 libhpc INFO] >> rigidbody_100.job running
[2022-03-07 12:16:57,398 libhpc INFO] >> Waiting... (60.00s)
[2022-03-07 12:17:59,970 libhpc INFO] >> Batch 1/6 took 67.45s to finish, 16.67% complete
[2022-03-07 12:17:59,971 libhpc INFO] > Running batch 2/6
[2022-03-07 12:18:02,325 libhpc INFO] >> rigidbody_101.job running
[2022-03-07 12:18:02,352 libhpc INFO] >> rigidbody_102.job running
...

@rvhonorato rvhonorato merged commit d863106 into main Mar 7, 2022
Bugs automation moved this from Needs triage to Closed Mar 7, 2022
@rvhonorato rvhonorato deleted the over100 branch March 7, 2022 17:53
@joaomcteixeira joaomcteixeira added the execution Related to execution modes, such as GRID, HPC, local, etc. label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Related to execution modes, such as GRID, HPC, local, etc.
Projects
Bugs
  
Closed
Development

Successfully merging this pull request may close these issues.

libhpc reporting % done going over 100
4 participants