Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for numbering reference between model and receptor #404

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

rvhonorato
Copy link
Member

@rvhonorato rvhonorato commented Apr 14, 2022

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:

  • You have stick to Python. Talk with us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there's a (state) purpose
  • code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any install dependencies unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 馃敟
  • Your PR is about writing tests for already existing code :godmode:

Before the alignment was just taking sections that overlap, now it should correctly use the numbering reference, also improved a bit the readability of the sequence alignment function and updated the tests.

- update tests
- improve function readability
@rvhonorato rvhonorato added the m|caprieval Improvements in caprieval module label Apr 14, 2022
@rvhonorato rvhonorato self-assigned this Apr 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #404 (af0c2fa) into main (c80475f) will increase coverage by 0.01%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
+ Coverage   62.53%   62.54%   +0.01%     
==========================================
  Files          70       70              
  Lines        4449     4451       +2     
==========================================
+ Hits         2782     2784       +2     
  Misses       1667     1667              
Impacted Files Coverage 螖
src/haddock/modules/analysis/caprieval/capri.py 82.59% <96.42%> (+0.05%) 猬嗭笍
tests/test_module_caprieval.py 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c80475f...af0c2fa. Read the comment docs.

Copy link
Contributor

@mgiulini mgiulini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I think there's also a major improvement in the overall code readability.

@mgiulini mgiulini merged commit 2143dfe into main Apr 14, 2022
@rvhonorato rvhonorato deleted the numbering_fix branch April 14, 2022 13:25
@joaomcteixeira joaomcteixeira added the bug Something isn't working label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working m|caprieval Improvements in caprieval module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants