-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate .rst
documentation page for .yaml
default configuration files
#436
Conversation
.rst
documentation page for .yaml
default configuration files.rst
documentation page for .yaml
default configuration files
Codecov Report
@@ Coverage Diff @@
## main #436 +/- ##
==========================================
- Coverage 71.14% 71.06% -0.09%
==========================================
Files 92 91 -1
Lines 5757 5737 -20
==========================================
- Hits 4096 4077 -19
+ Misses 1661 1660 -1
Continue to review full report at Codecov.
|
Thanks. for the comments. You are right, I will address that. |
thanks @mgiulini for the very nice comments and shape catches. I have improved the script and added docs. Have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool 馃憤
Co-authored-by: Marco Giulini <54807167+mgiulini@users.noreply.github.com>
Co-authored-by: Marco Giulini <54807167+mgiulini@users.noreply.github.com>
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:
tox
tests pass. Runtox
command inside the repository folder-test.cfg
examples execute without errors. Insideexamples/
runpython run_tests.py -b
Default parameters for each module, as well as general parameters and mandatory parameters, are defined in
yaml
files. However, these are not yet documented in the HD3 HTML doc pages.In this PR I introduce a script in the
devtools
folder that generate local.rst
pages with the documentation for theyaml
files.After you generate the docs locally:
tox -e docs
, you will find at the bottom of each module's documentation the yaml docs. Therefore, each module doc page will be composed of 3 sections:__init__.py
docstring for each moduleIn Reference -> Core there are also the mandatory parameters. And in the main module index page also the general module parameters.
Have a look and let me know your feelings. Obviously, it can be improved in the future. But I think the result is good. Btw, parameter names are heading meaning they can be clicked.
relevant note: we have parameters that are dictionaries, like
mol1
intopoaa
. This is okay. But the machinery here does not allow for more than one nesting level. Which I think is also a good human limit. Nothing to worry on this is just a note for the future.