Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed exported file names #650

Merged
merged 1 commit into from
May 15, 2023
Merged

changed exported file names #650

merged 1 commit into from
May 15, 2023

Conversation

mgiulini
Copy link
Contributor

@mgiulini mgiulini commented May 11, 2023

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Closes #644 by changing the attributes of the models exported by seletopclusts, so that downstream modules refer to the files dumped by seletopclusts and not to files generated by previous modules. The file seletopclusts.txt, containing the exact mapping between models has not been touched.

@mgiulini mgiulini self-assigned this May 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (241d502) 74.58% compared to head (3e52428) 74.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
- Coverage   74.58%   74.51%   -0.07%     
==========================================
  Files         111      111              
  Lines        7565     7572       +7     
==========================================
  Hits         5642     5642              
- Misses       1923     1930       +7     
Impacted Files Coverage Δ
...haddock/modules/analysis/seletopclusts/__init__.py 22.64% <0.00%> (-3.45%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mgiulini mgiulini merged commit dc90669 into main May 15, 2023
8 checks passed
@mgiulini mgiulini deleted the seletopclust_filenames branch May 15, 2023 08:09
@rvhonorato rvhonorato added enhancement Enhancing an existing feature of adding a new one m|seletopclusts labels May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancing an existing feature of adding a new one m|seletopclusts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change file names after seletopclust
4 participants