Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show gzipped structures in analysis report #758

Merged
merged 8 commits into from
Dec 14, 2023
Merged

Conversation

mgiulini
Copy link
Contributor

@mgiulini mgiulini commented Dec 13, 2023

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Closes #713 by adding a check on the clean configuration parameter. If clean is True, then the structures will be gzipped in the last stage of the workflow, thus making them unaccessible in the html report. To solve this, at the postprocessing stage we check the clean parameter. If True, the file names are modified by adding the .gz suffix.

Important : this PR cannot take care of the case in which clean is False at the global level and True at the module level (and vice versa), as this would require a complicated traceback at the postprocessing stage, which is out of the scope of the analysis. This is a very unlikely scenario.

@mgiulini mgiulini self-assigned this Dec 13, 2023
@mgiulini mgiulini added analysis/postprocessing related to the analysis/postprocessing of a haddock3 run bug Something isn't working labels Dec 13, 2023
@mgiulini mgiulini changed the title added is_cleaned logic show gzipped structures in analysis report Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b00edff) 72.46% compared to head (035c063) 72.54%.

Files Patch % Lines
src/haddock/libs/libplots.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
+ Coverage   72.46%   72.54%   +0.08%     
==========================================
  Files          80       80              
  Lines        7562     7566       +4     
==========================================
+ Hits         5480     5489       +9     
+ Misses       2082     2077       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgiulini mgiulini marked this pull request as ready for review December 13, 2023 14:26
src/haddock/libs/libplots.py Show resolved Hide resolved
@mgiulini mgiulini merged commit e56da8f into main Dec 14, 2023
6 checks passed
@mgiulini mgiulini deleted the show_gzipped_structures branch December 14, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis/postprocessing related to the analysis/postprocessing of a haddock3 run bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structures in analysis report not showing after clean
2 participants